-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Clarify compatibility #3694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify compatibility #3694
Conversation
- Add ASP.NET Core versions. - Clarify that Microsoft.AspNetCore.OpenApi is the only part of ASP.NET Core dependent on Microsoft.OpenApi. - Remove v7 from the compatibility table as 6.0 is now out-of-support. - Add link to SemVer website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the compatibility documentation to reflect current ASP.NET Core version support and clarifies dependency relationships. The changes remove outdated information about ASP.NET Core 6.0 (now out-of-support) and improve the accuracy of technical explanations.
- Added a link to the Semantic Versioning website for better context
- Clarified that only the Microsoft.AspNetCore.OpenApi NuGet package has a dependency on Microsoft.OpenApi v2+
- Removed v7 compatibility information from the table as ASP.NET Core 6.0 is no longer supported
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/migrating-to-v10.md | Added SemVer link reference and clarified that Microsoft.AspNetCore.OpenApi package specifically depends on Microsoft.OpenApi v2+ |
| README.md | Removed v7 compatibility row and updated ASP.NET Core version specifications from >= 8.0.0 to explicit version ranges (9.0.x, 8.0.x) for v9 and v8 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3694 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 111 111
Lines 3858 3858
Branches 778 778
=======================================
Hits 3652 3652
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updated [Swashbuckle.AspNetCore](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 10.0.1 to 10.1.0. <details> <summary>Release notes</summary> _Sourced from [Swashbuckle.AspNetCore's releases](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases)._ ## 10.1.0 ## What's Changed ### New Features * Add public method `SchemaRepository.ReplaceSchemaId` by @bkoelman in domaindrivendev/Swashbuckle.AspNetCore#3708 ### Bug Fixes * Exclude inherited properties only when base added to `AllOf` by @John-Paul-R in domaindrivendev/Swashbuckle.AspNetCore#3692 ### Miscellaneous * Add clarifying example in migration guide to v10 by @markuspalme in domaindrivendev/Swashbuckle.AspNetCore#3672 * Add markdown linter by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3673 * Update dependencies by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3685 * Validate OpenAPI documents create valid C# clients by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3686 * End-to-end client validation tests by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3687 * Add NSwag client test by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3689 * Fix GitHub step summaries by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3691 * Clarify compatibility by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3694 * Update zizmor by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3695 * Suppress zizmor false-positive by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3696 * Refactor tests by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3705 * Use NuGet Trusted Publishing by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3574 * Annotate `TryLookupByType` with nullability hints by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3719 * Bump swagger-ui-dist to 5.31.0 by @dependabot in domaindrivendev/Swashbuckle.AspNetCore#3720 ## New Contributors * @markuspalme made their first contribution in domaindrivendev/Swashbuckle.AspNetCore#3672 * @John-Paul-R made their first contribution in domaindrivendev/Swashbuckle.AspNetCore#3692 **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v10.0.1...v10.1.0 Commits viewable in [compare view](domaindrivendev/Swashbuckle.AspNetCore@v10.0.1...v10.1.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Resolves #3693.